Repository navigation
fix: update asyncio_reduce example to the current reducer API (Fixes #338) - #390
Merged
vigith merged 1 commit intoNov 12, 2026
Merged
Conversation
Both scripts used AsyncReducer and aiorun, which are gone. Move them to ReduceAsyncServer, make the executor handler a Reducer that uses its own pool, and stop reading the event loop before one is running. The Dockerfile ran a missing example.py, and requests was not a dependency. Add the example to the image build matrix, as the TODO there asked. Fixes numaproj#338 Signed-off-by: Atishay Kasliwal <katishay@gmail.com>
atishay-kasliwal
requested review from
BulkBeing,
kohlisid and
vigith
as code owners
November 9, 2026 04:06
vigith
approved these changes
Nov 10, 2026
BulkBeing
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #338
Both scripts used
AsyncReducerandaiorun, which no longer exist. They now useReduceAsyncServer, and the executor version is aReducerthat gets its pool throughinit_args. I also fixed the Dockerfile, which ran a missingexample.py, addedrequestsas a dependency, and added the example to the image build matrix as the TODO there asked.Tested: built the image and ran both scripts in it, sending 10 reduce requests over gRPC each time, with a local server answering the pings on
host.docker.internal:9888. Also ranexecutorpool.pylocally withEXEC_TYPEset to thread, process and unset.