Repository navigation
Reject empty slice flags in CLI commands that require them - #4263
Draft
roman-khimov with Copilot wants to merge 2 commits into
Draft
roman-khimov with Copilot wants to merge 2 commits into
roman-khimov with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: roman-khimov <22092804+roman-khimov@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Check Cobra commands for slice flag emptiness
Reject empty slice flags in CLI commands that require them
Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cobra parses
--flag ""into an empty slice. This is indistinguishable from the flag being omitted, but it passes theMarkFlagRequiredcheck. Commands that loop over such a flag silently do nothing, or send a request with an empty list, instead of failing.Each of the commands below now fails fast with "provide at least one … via -- flag" when the parsed slice has no elements:
neofs-cli object lock: the--oidflag.neofs-cli control drop-objects: the--objectsflag.neofs-adm fschain: container IDs flag, checked ingetCIDs.neofs-lancetfstree and metaremove: the--addressesflag.object deletealready had this check, so it is unchanged.Not covered: other slice flags (shard IDs, attributes, search filters, session subjects, X-headers) are untouched. Their empty value is either a valid input or not clearly a bug. Say if you want them checked too.