Skip to content

sn: support N3 signatures for container operations - #4258

Merged
roman-khimov merged 1 commit into
masterfrom
fix/support-N3-signatures-for-container-requests
Oct 30, 2026
Merged

sn: support N3 signatures for container operations#4258
roman-khimov merged 1 commit into
masterfrom
fix/support-N3-signatures-for-container-requests

Conversation

@carpawell

@carpawell carpawell commented Oct 28, 2026

Copy link
Copy Markdown
Member

@cthulhu-rider validate that there is nothing different b/w object and container operations, and if there is a reason why they are not supported.

@carpawell carpawell self-assigned this Oct 28, 2026
@codecov

codecov Bot commented Oct 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.24%. Comparing base (92a252c) to head (6049842).

Files with missing lines Patch % Lines
pkg/services/container/server.go 33.33% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4258   +/-   ##
=======================================
  Coverage   32.23%   32.24%           
=======================================
  Files         673      673           
  Lines       41636    41636           
=======================================
+ Hits        13423    13425    +2     
+ Misses      28213    28211    -2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cthulhu-rider

cthulhu-rider commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

afair this wasn't necessary. The object service needed to correctly retrieve the sender's account for ACL

cthulhu-rider
cthulhu-rider approved these changes Oct 29, 2026
View reviewed changes

@cthulhu-rider cthulhu-rider left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CL

@carpawell
sn: support N3 signatures for container operations
6049842 
*Attributes are exceptions cause they have different requests structures, their
V2 versions will be supported in API v2.29.

Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
@carpawell
carpawell force-pushed the fix/support-N3-signatures-for-container-requests branch from 23404dd to 6049842 Compare October 29, 2026 12:47
@carpawell

carpawell commented Oct 29, 2026

Copy link
Copy Markdown
Member Author

CL

Since it is approved and will be merged, added a record. Not sure if anybody will ever use it. But it is consistent at least.

@carpawell

carpawell commented Oct 29, 2026

Copy link
Copy Markdown
Member Author

afair this wasn't necessary

Was it necessary for object service, though? My main question is why it should be supported for any request.

@cthulhu-rider

cthulhu-rider commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Was it necessary for object service, though?

afair some clients started to receive "unsupported scheme" to object requests. But I haven't heard of any problems with other services

@roman-khimov
roman-khimov merged commit 8960b2e into master Oct 30, 2026
24 of 25 checks passed
@roman-khimov
roman-khimov deleted the fix/support-N3-signatures-for-container-requests branch October 30, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes
@cthulhu-rider cthulhu-rider cthulhu-rider approved these changes
@End-rey End-rey Awaiting requested review from End-rey End-rey is a code owner

Assignees

@carpawell carpawell

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carpawell @cthulhu-rider @roman-khimov