Skip to content

sn: return container ID after container put timeout - #4254

Merged
roman-khimov merged 1 commit into
masterfrom
fix/return-container-id-when-there-is-chain-timeout
Oct 28, 2026
Merged

roman-khimov merged 1 commit into
masterfrom
fix/return-container-id-when-there-is-chain-timeout

Conversation

@carpawell

Copy link
Copy Markdown
Member

This is expected on node's server side and contract client can return it too.

@carpawell carpawell self-assigned this Oct 28, 2026
@carpawell
carpawell force-pushed the fix/return-container-id-when-there-is-chain-timeout branch 2 times, most recently from b78b52c to e1b3743 Compare October 28, 2026 10:02
This is expected on node's server side and contract client can return it too.

Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
@carpawell
carpawell force-pushed the fix/return-container-id-when-there-is-chain-timeout branch from e1b3743 to 13fbc3e Compare October 28, 2026 10:03
@carpawell
carpawell marked this pull request as ready for review October 28, 2026 10:03
@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.25%. Comparing base (17843ab) to head (13fbc3e).

Files with missing lines Patch % Lines
pkg/morph/client/container/put.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4254   +/-   ##
=======================================
  Coverage   32.25%   32.25%           
=======================================
  Files         673      673           
  Lines       41622    41624    +2     
=======================================
+ Hits        13424    13425    +1     
- Misses      28198    28199    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread pkg/morph/client/container/put.go Resolved
@roman-khimov
roman-khimov merged commit fc586ec into master Oct 28, 2026
21 of 22 checks passed
@roman-khimov
roman-khimov deleted the fix/return-container-id-when-there-is-chain-timeout branch October 28, 2026 10:33
@roman-khimov roman-khimov added this to the v0.58.0 milestone Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants