Repository navigation
storage: encrypt session keys with HPKE - #4247
Merged
Merged
Conversation
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
October 22, 2026 15:32
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4247 +/- ##
==========================================
+ Coverage 32.29% 32.34% +0.04%
==========================================
Files 674 673 -1
Lines 41395 41405 +10
==========================================
+ Hits 13370 13391 +21
+ Misses 28025 28014 -11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
End-rey
force-pushed
the
proper-encryption-keys-in-session-storage
branch
from
October 22, 2026 15:52
f686867 to
0114549
Compare
Replace direct use of the node private key as an AES key with HPKE. Atomically migrate legacy records. Closes #3426. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Register engine cleanup before adding shards so GC workers stop before the test
finishes, including on assertion failures.
Fix:
```
panic: Log in goroutine after TestInitializationFailure has completed: 2026-10-22T15:35:31.098Z DEBUG started expired objects handling {"shard_id": "S5XQxiKfqKatUEhoHMwZ5M", "epoch": 0}
[recovered, repanicked]
goroutine 93 [running]:
sync.(*WaitGroup).Go.func1.1()
/opt/hostedtoolcache/go/1.27.3/x64/src/sync/waitgroup.go:251 +0x3a
panic({0x1c15dd8?, 0xc00032cfa0?})
/opt/hostedtoolcache/go/1.27.3/x64/src/runtime/panic.go:859 +0x125
testing.(*common).log(0xc0003ac6c8, {0xc0004bc380, 0x72}, 0x0)
/opt/hostedtoolcache/go/1.27.3/x64/src/testing/testing.go:1123 +0x1e7
testing.(*common).Logf(0xc0003ac6c8, {0x11f600a, 0x2}, {0xc00032cf70, 0x1, 0x1})
/opt/hostedtoolcache/go/1.27.3/x64/src/testing/testing.go:1345 +0x91
go.uber.org/zap/zaptest.TestingWriter.Write({{0x1cfa128?, 0xc0003ac6c8?}, 0x60?}, {0xc0002a2800, 0x73, 0x400})
/home/runner/go/pkg/mod/go.uber.org/zap@v1.28.0/zaptest/logger.go:146 +0x11a
go.uber.org/zap/zapcore.(*ioCore).Write(0xc0007daea0, {0xff, {0xc2aea930c5e3f97f, 0x709cbb486, 0x1d8e720}, {0x0, 0x0}, {0x1213392, 0x20}, {0x0, ...}, ...}, ...)
/home/runner/go/pkg/mod/go.uber.org/zap@v1.28.0/zapcore/core.go:99 +0x202
go.uber.org/zap/zapcore.(*CheckedEntry).Write(0xc0006e80e0, {0x0, 0x0, 0x0})
/home/runner/go/pkg/mod/go.uber.org/zap@v1.28.0/zapcore/entry.go:276 +0x568
go.uber.org/zap.(*Logger).Debug(0xc000902900, {0x1213392, 0x20}, {0x0, 0x0, 0x0})
/home/runner/go/pkg/mod/go.uber.org/zap@v1.28.0/logger.go:239 +0x68
github.com/nspcc-dev/neofs-node/pkg/local_object_storage/shard.(*Shard).collectExpiredObjects(0xc0000a2620)
/home/runner/work/neofs-node/neofs-node/pkg/local_object_storage/shard/gc.go:192 +0x22b
github.com/nspcc-dev/neofs-node/pkg/local_object_storage/shard.(*Shard).removeGarbage(0xc0000a2620)
/home/runner/work/neofs-node/neofs-node/pkg/local_object_storage/shard/gc.go:134 +0x3f
github.com/nspcc-dev/neofs-node/pkg/local_object_storage/shard.(*gc).tickRemover(0xc0000b6410)
/home/runner/work/neofs-node/neofs-node/pkg/local_object_storage/shard/gc.go:112 +0x96
sync.(*WaitGroup).Go.func1()
/opt/hostedtoolcache/go/1.27.3/x64/src/sync/waitgroup.go:258 +0x4a
created by sync.(*WaitGroup).Go in goroutine 71
/opt/hostedtoolcache/go/1.27.3/x64/src/sync/waitgroup.go:238 +0x73
FAIL github.com/nspcc-dev/neofs-node/pkg/local_object_storage/engine 30.356s
```
Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
force-pushed
the
proper-encryption-keys-in-session-storage
branch
from
October 22, 2026 19:39
0114549 to
ab4e5b0
Compare
roman-khimov
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3426.