Repository navigation
*: document disallowed duplicates for (*PrepareRequest).Transactions - #167
Merged
Merged
Conversation
Previous library version (prior to #164) was tolerant to transaction duplicates in the proposal. The updated version will construct improper block (with duplicated transactions set to `nil`) which may lead to a panic on the calle's side. Ref. nspcc-dev/neo-go#4387 (comment). Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
extend-comment
branch
from
October 14, 2026 16:46
f96a710 to
da601a8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
=======================================
Coverage 62.11% 62.11%
=======================================
Files 32 32
Lines 1560 1560
=======================================
Hits 969 969
Misses 590 590
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
roman-khimov
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous library version (prior to #164) was tolerant to transaction duplicates in the proposal. The updated version will construct improper block (with duplicated transactions set to
nil) which may lead to a panic on the calle's side. Ref.nspcc-dev/neo-go#4387 (comment).