This repository was archived by the owner on Oct 13, 2026. It is now read-only.
Repository navigation
feat: a nook runs code when it has a run command, not when it says so - #7
Merged
Merged
Conversation
type is gone from the manifest. A nook is a folder; if the manifest has a run
command, something runs it, and if it does not, the folder is a page. There is
nothing left to declare and nothing to get wrong.
Files written before this still parse: type is read and ignored, including a
type nobody ever defined, so nothing on disk breaks. It is never written back
out, so a pull, an export, or nook init never teaches it to anyone again. A
manifest claiming "service" without a run command is simply a page.
Everything that only means something alongside run — port, secrets, egress,
cron, source — now says so by name when it appears without one.
nook init writes { "name": "..." } and the examples and SKILL.md lose the field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vishal's call, relayed: drop
typefrom the manifest and infer fromrun. Doing it now, before anything downstream teaches agents a field we are removing.{ "name": "board", "run": "python app.py", "port": 8000, "secrets": ["SLACK_TOKEN"] }IsService()isRun != "". A nook is a folder; if the manifest has a run command, something runs it, and if it does not, the folder is a page.typeis read and ignored — including a value nobody ever defined, which used to be a hard error and now simply does not decide anything. Nothing on disk breaks.json:"-", so a pull, an export, ornook initcannot teach it to anyone again. There is a test asserting the marshalled form has notype."service"with no run command is a page, which is the honest reading once the field stops being authoritative.run—port,secrets,egress,cron,source— now says so by name when it appears without one.nook initwrites{ "name": "..." }. The five examples and SKILL.md lose the field.Source visibility is unchanged: editors-only when there is a run command.
nookd needs a v0.5.0 tag of this before its own half can land — that PR reads
Runrather than the type and drops "service nook" from everything user-facing.Part of ENG-24