This repository was archived by the owner on Oct 13, 2026. It is now read-only.
Repository navigation
fix: a where with two fields filters on both - #10
Merged
Merged
Conversation
list() built the query with one where= parameter, overwritten per field, so only the last one survived. The server reads where as a repeated parameter and ands them, which is what nook.js has always sent. A caller asking for two conditions got the rows matching one of them and no indication anything had been dropped. Both helpers append now, and a test pins it in each.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your nit, fixed now rather than later, because it is a silent wrong answer rather than an error.
list()built the query with onewhere=parameter overwritten per field, so only the last survived. The server readswhereas a repeated parameter and ANDs them — which is whatnook.jshas always sent. So a caller asking for two conditions got the rows matching one of them, with nothing to indicate a filter had been dropped: more rows than asked for, quietly.Both helpers append now (
doseq=Trueon the Python side), with a test pinning each.I would rather this went into v0.6.0 than trailed it, since the helpers are new and nobody has written against them yet. If the tag is already cut, v0.6.1 and I will bump nookd to that instead.
Separately: the
.pycwas mine. I ran the module to check it imported and then staged withgit add -A, which is the third time this week that has swept up something I did not write — a landing-page edit, a commit onto another session's branch, now this. I am staging explicit paths from here. Thanks for the.gitignore.Part of ENG-24