fix: selectively re-enable SIMD for ppc64 - #5776
Open
richardlau wants to merge 1 commit into
Open
Conversation
Fixes for WASM SIMD on Power >= 9 went into Node.js 25.0.0 and 24.12.0. Re-enable SIMD by default for ppc64, and only disable for the older unpatched versions of Node.js. Signed-off-by: Richard Lau <richard.lau@ibm.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5776 +/- ##
==========================================
- Coverage 93.51% 93.50% -0.02%
==========================================
Files 110 110
Lines 39324 39330 +6
==========================================
+ Hits 36774 36775 +1
- Misses 2550 2555 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
WASM SIMD was disabled by default for all ppc64 due to a bug in V8 on Power >= 9. The fix went into Node.js 25.0.0 and 24.12.0.
Changes
Re-enable SIMD by default for ppc64, and only disable when running on the older unpatched versions of Node.js.
Features
N/A
Bug Fixes
WASM SIMD is re-enabled for ppc64 on Node.js versions known to contain the V8 fix.
Breaking Changes and Deprecations
N/A
Status