fix: meriyah export map Nitro/Rollup issue

[timfish]

meriyah changed its export map for 6.1.0 and removed the import condition:

version	exports
5.0.0	{"import": "./dist/meriyah.esm.mjs", "require": "./dist/meriyah.cjs", ...}
6.0.0	{"import": "./dist/meriyah.min.mjs", "require": "./dist/meriyah.cjs", ...}
6.1.0+	{"module-sync": "./dist/meriyah.mjs", "require": "./dist/meriyah.cjs", "default": "./dist/meriyah.mjs"} — no plain "import" key

This causes issues with Nitro and/or the Rollup CommonJs plugin which fails to resolve the required files. The module then can't be found at runtime.

I opened a PR to add this back in meriyah:

• fix: import removed from export map meriyah/meriyah#585

However, they are a major ahead of us. Even if this gets merged we can't use it without dropping Node v18 support. @nodejs/orchestrion-js-maintainers does anyone else still need to support Node v18?

I also opened an issue for Nitro:

• Nested dependency silently missing when its exports map has no import condition nitrojs/nitro#4456

This PR downgrades to a meriyah version which doesn't cause the issue. Hopefully we can revert this at some point or upgrade to v7?

[AbhiPrasad]

I would be fine with dropping Node 18, but it did only EOL last year so the extended compat window is nice.

[jsumners-nr]

Dropping v18 is fine by me.

[jsumners-nr]

I don't understand how this will solve the described issue. I would expect 6.0.0 or >=6.0.0 <6.1.0.

[timfish]

Ah good catch, this should be ~6.0.0!

[timfish]

@bengl @rochdev does datadog still need v18 support?

This has been merged in meriyah@v7 which is Node >= v20.

[rochdev]

does datadog still need v18 support?

@timfish We do as it is still supported until next year 😅 Maybe it could accept a custom parser and we could pass our own Meriyah?

[rochdev]

I wonder why Meriyah dropped support to begin with though, for something as simple as a parser it shouldn't be hard to support older versions of Node 🤔

[timfish]

I wonder why Meriyah dropped support to begin with though, for something as simple as a parser it shouldn't be hard to support older versions of Node

Exactly!

We do as it is still supported until next year

That's perfectly fine, I just wanted to double check if there was an easy fix.

For now we just bundle the dependencies for our CJS output and everything becomes simple require to a path. No resolving. No issues with tooling. Once we can upgrade in the future, we can drop this workaround!