Repository navigation
chore: set pnpm to download on fail - #9245
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9245 +/- ##
==========================================
- Coverage 86.14% 86.12% -0.02%
==========================================
Files 87 87
Lines 6149 6149
Branches 369 369
==========================================
- Hits 5297 5296 -1
- Misses 848 849 +1
Partials 4 4 ☔ View full report in Codecov by Harness. |
There was a problem hiding this comment.
🟢 Approval recommended
The change enabling automatic downloads of the pinned pnpm version has no active review issues.
No open issues 🎉
What changed in this PR
Updates the repository’s pnpm configuration so version mismatches trigger downloading and switching to the pinned version rather than stopping with an error.
Changes:
- Changes
devEngines.packageManager.onFailfromerrortodownload, keeping pnpm pinned to12.8.1.
| File | Description |
|---|---|
package.json |
Enables automatic pnpm version downloading on mismatch. |
Review effort: Balanced
📦 Build Size ComparisonSummary
|
araujogui
left a comment
There was a problem hiding this comment.
It looks like PNPM can also manage Node.js versions: https://pnpm.io/cli/runtime
Yah, that's not something I use, and I don't think needs any changes in this PR? I don't want to have anything tooling-opinionated where possible; really, would rather have things done in a way where folks can use whatever tooling they desire. |
Description
I have pnpm installed through their recommended installation method as a global binary, which is designed to manage/switch versions itself. However, with this repo, the current setup causes it to just bail out due to
errorbeing set:Instead, we can set it
download, allowing pnpm to manage its own versions and download/switch to the correct version:Validation
pnpm continues to work locally for folks.
Related Issues
N/A
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.