Skip to content

chore(sidebar): use chevron for dropdown#8997

Merged
avivkeller merged 1 commit into
mainfrom
chevron
Jul 6, 2026
Merged

chore(sidebar): use chevron for dropdown#8997
avivkeller merged 1 commit into
mainfrom
chevron

Conversation

@avivkeller

@avivkeller avivkeller commented Jul 4, 2026

Copy link
Copy Markdown
Member

Copilot AI review requested due to automatic review settings July 4, 2026 19:54
@avivkeller avivkeller requested a review from a team as a code owner July 4, 2026 19:54
@vercel

vercel Bot commented Jul 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Jul 4, 2026 7:55pm

Request Review

@cursor

cursor Bot commented Jul 4, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Presentational sidebar UI only; no routing, data, or auth changes.

Overview
Nested sidebar sections that use <details> now show a chevron beside the label so expand/collapse is clearer.

The icon uses new .chevron styles: neutral by default, brand color and 180° rotation when the group is open, with a motion-safe transform transition. Behavior (auto-open when a child route is active) is unchanged.

Reviewed by Cursor Bugbot for commit bfcfe67. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov

codecov Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.41%. Comparing base (a5b11b7) to head (bfcfe67).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8997      +/-   ##
==========================================
+ Coverage   75.39%   75.41%   +0.02%     
==========================================
  Files          98       98              
  Lines        8636     8636              
  Branches      318      318              
==========================================
+ Hits         6511     6513       +2     
+ Misses       2121     2119       -2     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SidebarGroup UI so expandable sidebar subgroups use a consistent chevron icon indicator (instead of the native disclosure marker), matching the visual affordance used by other dropdown-like components in ui-components.

Changes:

  • Add a ChevronDownIcon to subgroup <summary> elements in SidebarGroup.
  • Style the chevron (size/color) and rotate it when the <details> is open.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/ui-components/src/Containers/Sidebar/SidebarGroup/index.tsx Renders a chevron icon alongside subgroup labels in the <summary>.
packages/ui-components/src/Containers/Sidebar/SidebarGroup/index.module.css Adds chevron styling and rotates it in the [open] state.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 94 🟢 93 🟢 96 🟢 100 🔗
/en/about 🟢 100 🟢 94 🟢 96 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 97 🟢 96 🟢 100 🔗
/en/download 🟢 99 🟢 96 🟠 81 🟢 100 🔗
/en/download/archive/current 🟢 100 🟢 97 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 97 🟢 96 🟢 100 🔗

@AugustinMauroy AugustinMauroy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@avivkeller avivkeller added this pull request to the merge queue Jul 6, 2026
Merged via the queue into main with commit 4fd34e2 Jul 6, 2026
22 checks passed
@avivkeller avivkeller deleted the chevron branch July 6, 2026 20:40
@bjohansebas

Copy link
Copy Markdown
Member

By the way, it was LGTM as well. It looks like I just never submitted the review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants