Skip to content

build: run QUIC CI for V8 changes - #66602

Open
inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:quic-ci-v8-changes
Open

build: run QUIC CI for V8 changes#66602
inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:quic-ci-v8-changes

Conversation

@inoway46

@inoway46 inoway46 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Add deps/v8/** to the QUIC workflow's PR path filter so V8 updates trigger its build and tests.

The V8 15.5 update did not trigger QUIC CI, allowing the SetPrototypeV2 compilation failure to go undetected.

Refs: #66537
Refs: https://github.com/nodejs/node/actions/runs/37675498427/job/112978479932

@nodejs-github-bot

nodejs-github-bot commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 8, 2026
@inoway46
inoway46 marked this pull request as ready for review October 8, 2026 12:57
@richardlau

richardlau commented Oct 8, 2026

Copy link
Copy Markdown
Member

The V8 15.5 update did not trigger QUIC CI, allowing the SetPrototypeV2 compilation failure to go undetected.

Was that fixed? It caused the QUIC CI to fail for #66569 and I was asked if it was due to the changes there or not (sounds like not).

@inoway46

inoway46 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Not yet. I’m currently investigating the compilation failure and testing a local build. It appears to be unrelated to #66569.

@inoway46 inoway46 mentioned this pull request Oct 8, 2026
Merged
@inoway46

inoway46 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

I've opened #66603 with a fix for the QUIC build failure.

@pimterry

pimterry commented Oct 8, 2026

Copy link
Copy Markdown
Member

Very happy for this to be enabled to help keep the QUIC build green, but QUIC is complicated and still quite rough around the edges, so you might run into flakes etc if we're running these tests more frequently.

Probably not a problem as long as you're aware and willing to take the risk. If that does become an issue at all do feel free to disable it again, just ping @nodejs/quic and we'll dig into anything that breaks.

nodejs-github-bot pushed a commit that referenced this pull request Oct 10, 2026
@inoway46
quic: replace removed SetPrototypeV2 calls
8c1a7d3 
Use SetPrototype when creating application options and transport
parameter objects. V8 15.5 removed the deprecated SetPrototypeV2
wrapper, which delegated to SetPrototype, breaking QUIC builds.

Assisted-by: Codex
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
PR-URL: #66603
Refs: #66537
Refs: #66602
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@inoway46
build: run QUIC CI for V8 changes
c7f7eef 
Add deps/v8/** to the QUIC workflow's pull request path filter so
V8 updates trigger its build and tests.

Assisted-by: Codex
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes
+1 more reviewer
@bjohansebas bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@inoway46 @nodejs-github-bot @richardlau @pimterry @bjohansebas