Skip to content

build: enable -fvisibility to improve startup speeds #65526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avivkeller wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: enable -fvisibility to improve startup speeds #65526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion deps/ada/ada.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,21 @@
'dependencies': [
'../../tools/v8_gypfiles/v8.gyp:simdutf',
],
'sources': [ '<@(ada_sources)' ]
'sources': [ '<@(ada_sources)' ],
'conditions': [
# See the same setting in node.gyp.
['node_shared=="false" and OS=="mac"', {
'xcode_settings': {
'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES' # -fvisibility-inlines-hidden
},
}, 'node_shared=="false" and (OS!="aix" and OS!="os400") and (OS!="win" or clang==1)', {
'cflags': [
'-fvisibility=hidden',
'-fvisibility-inlines-hidden'
],
}], # MSVC hides the non-public symbols by default so no need to configure it.
],
},
]
}
28 changes: 15 additions & 13 deletions node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,19 +538,21 @@
['clang==0 and OS!="win"', {
'cflags': [ '-Wno-restrict', ],
}],
# TODO(joyeecheung): investigate if it breaks addons.
# ['OS=="mac"', {
# 'xcode_settings': {
# 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
# 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES' # -fvisibility-inlines-hidden
# },
# }],
# ['OS!="win" or clang==1', {
# 'cflags': [
# '-fvisibility=hidden',
# '-fvisibility-inlines-hidden'
# ],
# }],
# Build with -fvisibility=hidden and -fvisibility-inlines-hidden to avoid
# including unnecessary internal symbols, which may lead to run-time fixups.
# This is not done on AIX where symbols are exported by tools/create_expfile.sh
# see https://github.com/nodejs/node/pull/56290#issuecomment-2582703109
['node_shared=="false" and OS=="mac"', {
'xcode_settings': {
'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES' # -fvisibility-inlines-hidden
},
}, 'node_shared=="false" and (OS!="aix" and OS!="os400") and (OS!="win" or clang==1)', {
'cflags': [
'-fvisibility=hidden',
'-fvisibility-inlines-hidden'
],
}], # MSVC hides the non-public symbols by default so no need to configure it.
# Pointer authentication for ARM64.
['target_arch=="arm64"', {
'target_conditions': [
Expand Down
3 changes: 1 addition & 2 deletions src/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1240,8 +1240,7 @@ NODE_EXTERN v8::Local<v8::Value> WinapiErrnoException(
const char* path = nullptr);
#endif

const char* signo_string(int errorno);

NODE_EXTERN const char* signo_string(int errorno);

typedef void (*addon_register_func)(
v8::Local<v8::Object> exports,
Expand Down
12 changes: 12 additions & 0 deletions tools/icu/icu-generic.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,18 @@
[ 'OS == "mac" or OS == "ios"', {
'xcode_settings': {'GCC_ENABLE_CPP_RTTI': 'YES' },
}],
# See the same setting in node.gyp.
['node_shared=="false" and OS=="mac"', {
'xcode_settings': {
'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES' # -fvisibility-inlines-hidden
},
}, 'node_shared=="false" and (OS!="aix" and OS!="os400") and (OS!="win" or clang==1)', {
'cflags': [
'-fvisibility=hidden',
'-fvisibility-inlines-hidden'
],
}], # MSVC hides the non-public symbols by default so no need to configure it.
[ 'OS == "win"', {
'msvs_settings': {
'VCCLCompilerTool': {'RuntimeTypeInfo': 'true'},
Expand Down
12 changes: 12 additions & 0 deletions tools/v8_gypfiles/abseil.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,18 @@
'<(ABSEIL_ROOT)/absl/time/internal/cctz/src/time_zone_name_win.cc',
],
}],
# See the same setting in node.gyp.
['node_shared=="false" and OS=="mac"', {
'xcode_settings': {
'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES' # -fvisibility-inlines-hidden
},
}, 'node_shared=="false" and (OS!="aix" and OS!="os400") and (OS!="win" or clang==1)', {
'cflags': [
'-fvisibility=hidden',
'-fvisibility-inlines-hidden'
],
}], # MSVC hides the non-public symbols by default so no need to configure it.
],
}, # abseil
]
Expand Down
5 changes: 1 addition & 4 deletions tools/v8_gypfiles/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,7 @@
}
},
'conditions': [
# Build with -fvisibility=hidden and -fvisibility-inlines-hidden to avoid
# including unnecessary internal symbols, which may lead to run-time fixups.
# This is not done on AIX where symbols are exported by tools/create_expfile.sh
# see https://github.com/nodejs/node/pull/56290#issuecomment-2582703109
# See the same setting in node.gyp
['OS!="aix" and OS!="os400"', {
'defines': [
'BUILDING_V8_SHARED', # Make V8_EXPORT visible.
Expand Down
Loading