typings: add encodeIntoResults to EncodingBinding - #65350
Merged
nodejs-github-bot merged 1 commit intoAug 29, 2026
Merged
Conversation
Signed-off-by: greenhead <shren0812@gmail.com>
nodejs-github-bot
added
the
typings
jasnell
approved these changes
Aug 17, 2026
daeyeon
added
author ready
Collaborator
|
Landed in 6cff903 |
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Aug 29, 2026
Signed-off-by: greenhead <shren0812@gmail.com> PR-URL: #65350 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the existing
encodeIntoResultsUint32Arrayproperty to the internalEncodingBindingdeclaration.The native binding exposes this two-element result buffer, and
lib/internal/encoding.jsalready consumes it for thereadandwrittenvalues returned byTextEncoder.encodeInto().No runtime behavior is changed.
Tests:
make JOBS=10./node test/wpt/test-encoding.jsTS2339before the change and no diagnostics after