net: expand BlockList.PRIVATE_RANGES (unspecified, CGNAT, benchmarking) - #65204
Open
SashaMIT wants to merge 2 commits into
Open
net: expand BlockList.PRIVATE_RANGES (unspecified, CGNAT, benchmarking)#65204SashaMIT wants to merge 2 commits into
SashaMIT wants to merge 2 commits into
Conversation
PRIVATE_RANGES is documented as covering private, loopback, and link-local ranges used to block non-routable addresses. It already includes 127.0.0.0/8 and ::1/128 but omitted the IPv4 "this" network (0.0.0.0/8) and the IPv6 unspecified address (::/128), which are common alternate localhost spellings.
Collaborator
|
Review requested:
|
Include RFC 6598 (100.64.0.0/10) and RFC 2544 (198.18.0.0/15) so the helper matches common non-global IPv4 space used by carrier NAT and benchmarking labs.
Author
|
Follow-up commit on this branch: also include RFC 6598 CGNAT ( Same unreleased-API helper surface as the |
SashaMIT
changed the title
jasnell
approved these changes
Aug 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65204 +/- ##
==========================================
- Coverage 90.31% 90.30% -0.02%
==========================================
Files 760 760
Lines 248532 248540 +8
Branches 46908 46902 -6
==========================================
- Hits 224467 224443 -24
+ Misses 15505 15503 -2
- Partials 8560 8594 +34
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BlockList.PRIVATE_RANGESis documented as a convenience list of private, loopback, and link-local ranges for blocking non-routable addresses. It already includes127.0.0.0/8and::1/128, but omitted:0.0.0.0/8(IPv4 "this" network / unspecified; common alternate localhost spelling)::/128(IPv6 unspecified)Callers who populate a blocklist from
PRIVATE_RANGESalone would still treat0.0.0.0and::as allowed.Test plan
test/parallel/test-blocklist.jsPRIVATE_RANGES coverage for0.0.0.0,0.0.0.1, and::doc/api/net.mdThis API is unreleased (
added: REPLACEME), so this is a constants/docs completion rather than a HackerOne report.Made with Cursor