tools: add workflow to compare Nix changes#64410
Open
aduh95 wants to merge 3 commits into
Open
Conversation
If a change breaks e.g. the benchmark workflow, it might be not obvious to detect as we typically do not run any benchmark when bumping the nixpkgs pin. The added workflows will verify that all derivations can be built on all platforms, and report the list of changes. Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
anonrig
approved these changes
Jul 10, 2026
panva
approved these changes
Jul 10, 2026
gurgunday
approved these changes
Jul 10, 2026
efekrskl
approved these changes
Jul 10, 2026
aduh95
added
author ready
Do not attempt to add comment on non-PR runs, i.e. when pushing to `main`.
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64410 ✔ Done loading data for nodejs/node/pull/64410 ----------------------------------- PR info ------------------------------------ Title tools: add workflow to compare Nix changes (#64410) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:nix-auto-review-derivation-diff -> nodejs:main Labels meta, author ready Commits 3 - tools: add workflow to compare Nix changes - fixup! tools: add workflow to compare Nix changes - fixup! tools: add workflow to compare Nix changes Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/64410 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64410 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - tools: add workflow to compare Nix changes ⚠ - fixup! tools: add workflow to compare Nix changes ⚠ - fixup! tools: add workflow to compare Nix changes ℹ This PR was created on Fri, 10 Jul 2026 14:25:34 GMT ✔ Approvals: 3 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/64410#pullrequestreview-4672506295 ✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/64410#pullrequestreview-4672864457 ✔ - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/64410#pullrequestreview-4672865845 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/29196706711 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a change breaks e.g. the benchmark workflow, it might be not obvious to detect as we typically do not run any benchmark when bumping the nixpkgs pin.
The added workflows will verify that all derivations can be built on all platforms, and report the list of changes by commenting on the PR.
I'm also moving the
lint-nixjob, so it no longer runs on PRs that do not touch Nix changes.I've tested this with aduh95#44