http: remove unused n arg from IncomingMessage._read

[efekrskl]

Something I came across while reading the code. We are on V8 version 14.6 and https://bugs.chromium.org/p/v8/issues/detail?id=10201 seems to be long fixed

Benchmarks look fine, no regression

node benchmark/compare.js --runs 20 --old /tmp/node-before --new ./out/Release/node --filter incoming_headers http

http/incoming_headers.js w=0  new: 92,861.1 req/s  old: 92,683.8 req/s  Δ +0.19%
http/incoming_headers.js w=6  new: 92,280.2 req/s  old: 92,099.9 req/s  Δ +0.20%

"binary","filename","configuration","rate","time"
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",88216,5.033902166
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91706,5.032816750
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92340,5.030441417
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92358,5.032705292
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92810,5.032385083
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91917,5.032915125
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",95465,5.035307834
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",94378,5.032257708
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91278,5.030846958
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91491,5.032964208
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93601,5.032840333
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91972,5.030918709
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92830,5.030898750
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93305,5.033278459
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92541,5.030804209
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93280,5.034695291
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93667,5.031394291
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92082,5.033757250
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",98752,5.032255875
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93297,5.031768750
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93255,5.032932458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93808,5.034575917
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91068,5.031090833
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92804,5.036295958
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91687,5.031114000
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92187,5.033795209
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92487,5.030943500
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90248,5.032132375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",96481,5.032132458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92391,5.032676667
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93567,5.034867000
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92793,5.033667750
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93374,5.032243500
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91300,5.033162291
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92952,5.031299625
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91788,5.032875833
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92984,5.030787000
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92553,5.033792291
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92685,5.032433000
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93327,5.034474708
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93767,5.032476959
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91779,5.033934792
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92912,5.032719500
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93419,5.036553375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93720,5.033281458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93450,5.033137417
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92272,5.031763125
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92573,5.034340792
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93181,5.033145250
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93393,5.032651166
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92785,5.030968208
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92127,5.033030667
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92631,5.033490542
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91117,5.033555083
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93560,5.033145417
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92785,5.033146792
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93619,5.033333709
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92852,5.032217875
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92003,5.031525458
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91929,5.033460375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91029,5.032543667
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90248,5.034893667
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",89940,5.032874750
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",88542,5.033250333
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",90748,5.032593125
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90293,5.034885000
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",88850,5.032433708
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",88772,5.031771625
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",90696,5.031554792
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90362,5.033429416
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92834,5.032394209
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92095,5.032017166
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",94268,5.031772667
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92035,5.033010458
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92885,5.035188625
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92955,5.034318459
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93434,5.032026500
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93730,5.030823625
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93722,5.036334833
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",94163,5.033176917

[nodejs-github-bot]

Review requested:

• @nodejs/http
• @nodejs/net

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.25%. Comparing base (799e910) to head (eb01019).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #64370   +/-   ##
=======================================
  Coverage   90.25%   90.25%           
=======================================
  Files         741      741           
  Lines      241165   241157    -8     
  Branches    45428    45427    -1     
=======================================
- Hits       217667   217660    -7     
  Misses      15069    15069           
+ Partials     8429     8428    -1     

Files with missing lines	Coverage Δ
lib/_http_incoming.js	99.37% <100.00%> (-0.02%)	⬇️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/74680/