fs: preserve readFile() errors for numeric file descriptors#64368
Open
jibin7jose wants to merge 1 commit into
Open
fs: preserve readFile() errors for numeric file descriptors#64368jibin7jose wants to merge 1 commit into
jibin7jose wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fs.readFile()with a numeric file descriptor and the newbufferoption could lose errors on the user-fd path.Root cause
In
lib/internal/fs/read/context.js,ReadFileContext.close(err)did not forwarderrwhenisUserFdwas true. As a result, failures that should have reached the callback, including an undersized caller-provided buffer, could be treated as successful completion.Fix
Forward the close error for user-supplied file descriptors so the final callback receives the actual failure instead of silently succeeding.
Tests
Add regression coverage for the numeric file descriptor path with:
This verifies the error is preserved for the callback-based API.
Fixes: #64367