test: cover worker throwing primitive values#64365
Open
dobbydobap wants to merge 1 commit into
Open
Conversation
A worker that throws a non-Error value (string, number, bigint, boolean, null, undefined) surfaces that value on the parent's 'error' handler. This was reported as a wrapped ERR_UNHANDLED_ERROR and is now correct, but had no regression coverage. Refs: nodejs#35506 Signed-off-by: dobbydobap <varshitha.kolupuri@gmail.com>
nodejs-github-bot
added
needs-ci
aduh95
reviewed
Jul 8, 2026
| { code: 'throw 7n;', value: 7n }, | ||
| { code: 'throw true;', value: true }, | ||
| { code: 'throw null;', value: null }, | ||
| { code: 'throw undefined;', value: undefined }, |
Contributor
There was a problem hiding this comment.
Let's add a symbol for completeness sake
Suggested change
| { code: 'throw undefined;', value: undefined }, | |
| { code: 'throw undefined;', value: undefined }, | |
| { code: 'throw Symbol.for("a");', value: Symbol.for('a') }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does: Adds a regression test asserting that when a worker throws a non-Error value (string, number, bigint, boolean, null, undefined), the parent's 'error' handler receives that value directly rather than a wrapped ERR_UNHANDLED_ERROR.
The behavior is already correct on
main; this adds the missing coverage so #35506 can't regress.How I tested
: python tools/test.py test/parallel/test-worker-error-primitive.js→ passes; also ran the file directly.