test_runner: add handleSignals option to run()#64357
Open
mete0rfish wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Signed-off-by: mete0rfish <sungwon326@naver.com>
463edaa to
0bfc0f9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64357 +/- ##
==========================================
- Coverage 92.01% 90.27% -1.75%
==========================================
Files 379 741 +362
Lines 166972 241004 +74032
Branches 25554 45422 +19868
==========================================
+ Hits 153639 217558 +63919
- Misses 13041 15018 +1977
- Partials 292 8428 +8136
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the TODO from #43977
The built-in test runner already handles
SIGINTandSIGTERM, marking any running tests as interrupted before exiting. Therun()API, however, did not provide a way to enable the same behavior.This change adds an opt-in
handleSignalsoption for test runner integrations:Signal handling remains disabled by default, so existing
run()users that manage process signals themselves are unaffected. Custom runners can now opt in when they need behavior consistent with the CLI test runner.