Skip to content

test: use heapdump test for SecureContext memory tracking#64344

Open
mertcanaltin wants to merge 3 commits into
nodejs:mainfrom
mertcanaltin:fix/remove-cctest-memory-tracking
Open

test: use heapdump test for SecureContext memory tracking#64344
mertcanaltin wants to merge 3 commits into
nodejs:mainfrom
mertcanaltin:fix/remove-cctest-memory-tracking

Conversation

@mertcanaltin

Copy link
Copy Markdown
Member

Replace cctest with a heap snapshot test for SecureContext memory tracking.

Refs: #59051

@joyeecheung #59051 (comment)

Signed-off-by: Mert Can Altin <mertgold60@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 7, 2026
Signed-off-by: Mert Can Altin <mertgold60@gmail.com>
@mertcanaltin

Copy link
Copy Markdown
Member Author

hey @joyeecheung I applied your last sugesstions (#62689 (comment), #62689 (comment))

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.23%. Comparing base (4ee2117) to head (5438c86).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64344      +/-   ##
==========================================
- Coverage   90.23%   90.23%   -0.01%     
==========================================
  Files         741      741              
  Lines      240979   240979              
  Branches    45401    45399       -2     
==========================================
- Hits       217449   217440       -9     
+ Misses      15112    15111       -1     
- Partials     8418     8428      +10     

see 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants