Skip to content

Detect Visual Studio when only VisualStudioVersion is set #3388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PerryLink wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Detect Visual Studio when only VisualStudioVersion is set #3388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3618c9
fix: fall back to VisualStudioVersion when VSCMD_VER is absent
PerryLink Oct 17, 2026
00a74e9
test: make the new Visual Studio case independent of the host archite…
PerryLink Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/find-visualstudio.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,10 @@ class VisualStudioFinder {
// VSCMD_VER environment variable which contains the version information
// for Visual Studio.
// https://learn.microsoft.com/en-us/visualstudio/ide/reference/command-prompt-powershell?view=vs-2022
version: process.env.VSCMD_VER,
// vcvarsall.bat also sets VisualStudioVersion ("Major.Minor"), which is
// enough for getVersionInfo(); some editor integrations invoke it without
// VsDevCmd.bat, so VSCMD_VER is not always set.
version: process.env.VSCMD_VER || process.env.VisualStudioVersion,
packages: [
'Microsoft.VisualStudio.Component.VC.Tools.x86.x64',
'Microsoft.VisualStudio.Component.VC.Tools.ARM64',
Expand Down
41 changes: 41 additions & 0 deletions test/test-find-visualstudio.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,4 +931,45 @@ describe('find-visualstudio', function () {
versionYear: 2019
})
})

it('run on a VS Command Prompt that only exports VisualStudioVersion', async function () {
// vcvarsall.bat sets VCINSTALLDIR and VisualStudioVersion, while VSCMD_VER
// is only set by VsDevCmd.bat. Some editor integrations only run
// vcvarsall.bat, so VSCMD_VER can be missing. See #3276.
process.env.VCINSTALLDIR =
'C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC'
delete process.env.VSCMD_VER
process.env.VisualStudioVersion = '17.0'
process.env.WindowsSDKVersion = '10.0.26100.0'

const finder = new TestVisualStudioFinder(semverV1, null)

// Simulate a host where the PowerShell based fallbacks are not usable
// (no VSSetup module, Add-Type unavailable), as on the machine in #3276.
finder.findNewVSUsingSetupModule = async () => null
finder.findNewVS = async () => null
finder.findVisualStudio2015 = async () => null
finder.findVisualStudio2013 = async () => null
finder.msBuildPathExists = () => true

const { err, info } = await finder.findVisualStudio()
assert.strictEqual(err, null)
const msBuildDir = 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\' +
'BuildTools\\MSBuild\\Current\\Bin'
assert.deepStrictEqual(info, {
// getMSBuild() prefers the arm64 copy when the host is arm64 and the file exists
msBuild: process.arch === 'arm64'
? msBuildDir + '\\arm64\\MSBuild.exe'
: msBuildDir + '\\MSBuild.exe',
path:
'C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools',
sdk: '10.0.26100.0',
toolset: 'v143',
// VisualStudioVersion only carries the major.minor part.
version: '17.0',
versionMajor: 17,
versionMinor: 0,
versionYear: 2022
})
})
})