feat: port test_general core to CTS - #72
Open
bavulapati wants to merge 3 commits into
Open
Conversation
This was referenced Aug 10, 2026
legendecas
reviewed
Aug 14, 2026
| @@ -0,0 +1,229 @@ | |||
| #include <js_native_api.h> | |||
Member
There was a problem hiding this comment.
Any reason this define is dropped?
Contributor
Author
There was a problem hiding this comment.
No good reason - dropped by oversight while trimming the addon. Restored in 48920d8 along with the upstream comment; our include/js_native_api.h honors the macro, so the compile-time check carries over. test_general still builds and passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the stable core of
test/js-native-api/test_general:test.js,testGlobals.js,testNapiRun.js,testNapiStatus.js.Two deliberate differences from upstream:
testGetVersion()is compared against the harnessnapiVersionglobal rather than the hardcoded10.node_api_set_prototypeis left out; it is experimental and lands as its own addon in a follow-up, so this addon stays loadable on every runtime.First of several small PRs for this directory (testInstanceOf, V8 instanceof, testFinalizer, testEnvCleanup, setPrototype follow). PORTING.md moves to Partial until they all land.