Repository navigation
ci: use .nvmrc for actions/setup-node - #2683
Merged
Merged
Conversation
Remove .node-version
nschonni
approved these changes
Nov 5, 2026
nschonni
left a comment
Member
There was a problem hiding this comment.
Left another (non-blocking) thought, but thanks for make the changes from the other thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change
actions/setup-nodeto use .nvmrc as defining version of Node.js in CI.Remove .node-version from the repo.
Modify documentation accordingly.
Motivation and Context
As discussed in #2679 it is not necessary to keep both files in the repo in order to support CI and local usage:
These two conventions have grown side-by-side. The name .node-version is not linked to any implementation, so it is often preferred for that reason. The name of the file also makes the intention clear. .nvmrc emerged from the https://github.com/nvm-sh/nvm utility that it is named after.
Most Node.js version managers, including
actions/setup-node, are compatible with .nvmrc. The nvm utility, on the other hand, never additionally adopted the .node-version convention.Testing Details
Tested in CI.
Types of changes
Checklist