Skip to content

ci: use .nvmrc for actions/setup-node - #2683

Merged
MikeMcC399 merged 1 commit into
nodejs:mainfrom
MikeMcC399:ci-move-to-nvmrc
Nov 6, 2026
Merged

MikeMcC399 merged 1 commit into
nodejs:mainfrom
MikeMcC399:ci-move-to-nvmrc

Conversation

@MikeMcC399

Copy link
Copy Markdown
Contributor

Description

Change actions/setup-node to use .nvmrc as defining version of Node.js in CI.

Remove .node-version from the repo.

Modify documentation accordingly.

Motivation and Context

As discussed in #2679 it is not necessary to keep both files in the repo in order to support CI and local usage:

These two conventions have grown side-by-side. The name .node-version is not linked to any implementation, so it is often preferred for that reason. The name of the file also makes the intention clear. .nvmrc emerged from the https://github.com/nvm-sh/nvm utility that it is named after.

Most Node.js version managers, including actions/setup-node, are compatible with .nvmrc. The nvm utility, on the other hand, never additionally adopted the .node-version convention.

Testing Details

Tested in CI.

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@MikeMcC399 MikeMcC399 self-assigned this Nov 5, 2026
@MikeMcC399 MikeMcC399 added the ci CI (Continuous Integration) workflows label Nov 5, 2026
@MikeMcC399
MikeMcC399 marked this pull request as ready for review November 5, 2026 13:00
@MikeMcC399
MikeMcC399 requested a review from nschonni November 5, 2026 13:01

@nschonni nschonni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left another (non-blocking) thought, but thanks for make the changes from the other thread.

Comment thread CONTRIBUTING.md Resolved
@MikeMcC399
MikeMcC399 merged commit 9102551 into nodejs:main Nov 6, 2026
4 checks passed
@MikeMcC399
MikeMcC399 deleted the ci-move-to-nvmrc branch November 6, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI (Continuous Integration) workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants