chore: set debian_default to trixie in config#2558
Open
MikeMcC399 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
This PR should have no effect on the current Dockerfile builds, since each of the Node.js releases includes both It only comes into play if |
fded952 to
acaee44
Compare
sxa
approved these changes
Jul 8, 2026
sxa
left a comment
Member
There was a problem hiding this comment.
Seems reasonable to me - I wouldn't expect any negative side effects from this although it would be good if at least one other person could approve too before merging :-)
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update.shfails to update with pruned variants #2438Description
In config, change the entry
default_variant:bookworm(Debian 12)trixie(Debian 13)Motivation and Context
default_variantis used in the following code to determine whether a Node.js version directory is valid or not:docker-node/functions.sh
Lines 152 to 156 in 3b32380
To allow for the flexibility of dropping
bookworm(Debian 12) from the configuration at some later stage, thedefault_variantis updated totrixie.Without this change, a Node.js version configuration that does not include
bookwormwould be ignored. (See issue #2438.)bookworm(Debian 12) already transitioned into end-of-life on 2026-06-10 and is now in its LTS stage with reduced architectural support. See also issue #2556.Testing Details
Make temporary changes:
rm -rf 26/bullseye*Edit versions.json to temporarily remove
bullseye&bullseye-slimfrom Node.js 26.Execute
./update.sh.Confirm that the logs show Node.js 26 being updated.
Test logs
Types of changes
Checklist