fix(vercel): update vercel scripts to build against latest Node.js release tag#888
fix(vercel): update vercel scripts to build against latest Node.js release tag#888bmuenzenmeyer wants to merge 1 commit into
Conversation
PR SummaryLow Risk Overview Build reads that tag and passes Reviewed by Cursor Bugbot for commit 63e6545. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #888 +/- ##
=======================================
Coverage 85.04% 85.04%
=======================================
Files 179 179
Lines 16496 16496
Branches 1500 1500
=======================================
Hits 14029 14029
Misses 2457 2457
Partials 10 10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| File | Base | Head | Diff |
|---|---|---|---|
all.html |
19.94 MB | 19.94 MB | -234.00 B (-0.00%) |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 63e6545. Configure here.
| -i "./node/doc/api/*.md" \ | ||
| -o "./out" \ | ||
| -c "./node/CHANGELOG.md" \ | ||
| -v "$NODE_VERSION" \ |
There was a problem hiding this comment.
Release tag not used for git refs
Medium Severity
The prepare step now clones nodejs/node at a concrete release tag and the build passes that tag as -v, but nothing updates ref. Generated GitHub edit and source links still resolve via the default-branch defaults (HEAD / main), so they no longer match the release the docs were built from.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 63e6545. Configure here.


Description
Per feedback, we should use upstream node latest tagged version, not the
process.versionValidation
Should build against 26.5.0 at time of writing
Related Issues
Part of nodejs/nodejs.org#8998
Check List
node --run testand all tests passed.node --run format&node --run lint.