fix: strip trailing slash from COREPACK_NPM_REGISTRY#871
Open
bitpshr wants to merge 1 commit into
Open
Conversation
A `COREPACK_NPM_REGISTRY` value with a trailing slash produced request URLs with a double slash (e.g. `https://registry.npmjs.org//pnpm`). registry.npmjs.org tolerates this, but some registries such as registry.npmmirror.com reject it with a 404. Normalize the registry URL by removing trailing slashes before building request URLs. Fixes: nodejs#711 Signed-off-by: Paul Bouchon <mail@bitpshr.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #711.
A
COREPACK_NPM_REGISTRYwith a trailing slash produced request URLs with a double slash (e.g.https://registry.npmjs.org//pnpm), which some registries like registry.npmmirror.com reject with a 404. Normalize the registry URL by stripping trailing slashes before building request URLs. Added a regression test.