Skip to content

chore: self-maintain Node.js features - #467

Merged
marco-ippolito merged 1 commit into
nodejs:mainfrom
forked-by-avivkeller:nodejs-self-maintain
Oct 20, 2026
Merged

marco-ippolito merged 1 commit into
nodejs:mainfrom
forked-by-avivkeller:nodejs-self-maintain

Conversation

@avivkeller

@avivkeller avivkeller commented Sep 20, 2026 •

Copy link
Copy Markdown
Member

Alternative solution to swc-project/swc#12395 (fixes swc-project/swc#12378). The majority of this PR is the removal of swc as a vendored dependency, and instead it's updating will be handled by Dependabot (since this package no longer needs to be compiled to WASM on update, it's now just a regular dependency).

This also reduces Amaro's built size by ~1MB.

This PR makes Amaro a rust crate that depends on SWC, rather than a wrapper around a custom SWC crate. The changes were were heavily inspired from and pieces were taken from SWC, so let me know how I should Co-Author y'all.


Note: Commit 3d891b8 only removes files.

@avivkeller
avivkeller marked this pull request as ready for review September 20, 2026 19:45
@avivkeller

Copy link
Copy Markdown
Member Author

cc @kdy1 @magic-akari

@kdy1

kdy1 commented Sep 21, 2026

Copy link
Copy Markdown
Member

I like this approach, but I'm not sure we can remove the vendored source code from this repository.

@avivkeller

Copy link
Copy Markdown
Member Author

I'm not sure we can remove the vendored source code from this repository.

Can you elaborate on why not? It's still a dependency, but no longer one that's embedded in this repo's source, since it's a regular crate dep

@kdy1

kdy1 commented Sep 21, 2026

Copy link
Copy Markdown
Member

@marco-ippolito Can we remove the vendoring of the SWC source code?

@marco-ippolito

Copy link
Copy Markdown
Member

@marco-ippolito Can we remove the vendoring of the SWC source code?

@nodejs/security-wg I think it can be done, there hasnt been much benefit in vendoring swc so far

@avivkeller

Copy link
Copy Markdown
Member Author

Bump!

1 similar comment
@avivkeller

Copy link
Copy Markdown
Member Author

Bump!

@marco-ippolito

Copy link
Copy Markdown
Member

requires a rebase, also does it reduce the wasm size?

@kdy1

kdy1 commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

I don't expect it to reduce the size of Wasm, but I need this to be merged to do cool optimization (Switching to https://github.com/swc-project/swc-next)

@avivkeller

Copy link
Copy Markdown
Member Author

I'll rebase once there's an approval so that I don't need to keep rebasing as we wait for approvals.

@avivkeller

Copy link
Copy Markdown
Member Author

Yes, it reduces the WASM size,

This also reduces Amaro's built size by ~1MB.

@marco-ippolito

Copy link
Copy Markdown
Member

Lets do it

@avivkeller
avivkeller force-pushed the nodejs-self-maintain branch from dab862a to 8ffea76 Compare October 20, 2026 15:38
@avivkeller

Copy link
Copy Markdown
Member Author

Rebased!

@marco-ippolito
marco-ippolito merged commit 1d7e012 into nodejs:main Oct 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node.js Amaro Features

3 participants