Repository navigation
chore: self-maintain Node.js features - #467
Conversation
4e13bd9 to
20f14bb
Compare
|
I like this approach, but I'm not sure we can remove the vendored source code from this repository. |
Can you elaborate on why not? It's still a dependency, but no longer one that's embedded in this repo's source, since it's a regular crate dep |
|
@marco-ippolito Can we remove the vendoring of the SWC source code? |
@nodejs/security-wg I think it can be done, there hasnt been much benefit in vendoring swc so far |
|
Bump! |
1 similar comment
|
Bump! |
|
requires a rebase, also does it reduce the wasm size? |
|
I don't expect it to reduce the size of Wasm, but I need this to be merged to do cool optimization (Switching to https://github.com/swc-project/swc-next) |
|
I'll rebase once there's an approval so that I don't need to keep rebasing as we wait for approvals. |
|
Yes, it reduces the WASM size,
|
|
Lets do it |
dab862a to
8ffea76
Compare
|
Rebased! |
Alternative solution to swc-project/swc#12395 (fixes swc-project/swc#12378). The majority of this PR is the removal of swc as a vendored dependency, and instead it's updating will be handled by Dependabot (since this package no longer needs to be compiled to WASM on update, it's now just a regular dependency).
This also reduces Amaro's built size by ~1MB.
This PR makes Amaro a rust crate that depends on SWC, rather than a wrapper around a custom SWC crate. The changes were were heavily inspired from and pieces were taken from SWC, so let me know how I should Co-Author y'all.
Note: Commit 3d891b8 only removes files.