Skip to content

revisit getParents and getDeps #49

Description

@paciorek

These are essentially fully set up, but some questions are arising.

  1. At the moment, these are framed as returning varRanges rather than nodeRanges. However what is returned are fundamentally nodeRanges as I pass results of graphRules through the declRules in order to exclude RHS only.
  2. Given that nimble returns nodes, I think we should probably do the same in nimbleModel.
  3. I haven't yet implemented various args that are present in nimble, namely determOnly, stochOnly, includeData, dataOnly, includeRHSonly, predictiveOnly, includePredictive.

So I think the path forward is to pass results through getNodes, including the various "include/only" flags. This will also address duplication (issue #36) once I add deduplication in getNodes.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions