Skip to content

reconsider class structure for instructions in R #48

Description

@paciorek

In PR #44 I reworked how we handle instructions in R to make it much faster in the multi-sortID case.

In that PR I had this note, which is still something for us to consider:

For handling the resulting R list of "R instr", for the moment I made it an S3 class "Rlist_Rinstr". We could consider making an R6 class for the overall list and an R6 class for the inner lists. At the least if we do the former, we can give it an isCompiled method and that will fit into the existing checking in calc_op and simulate. Using S3 doesn't fit within our standard style.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions