Skip to content

test(spec): cover default condition and measurement mapping formats - #243

Open
Ahalya-ni wants to merge 1 commit into
masterfrom
test/spec-dataframe-default-formats
Open

Ahalya-ni wants to merge 1 commit into
masterfrom
test/spec-dataframe-default-formats

Conversation

@Ahalya-ni

@Ahalya-ni Ahalya-ni commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

What does this Pull Request accomplish?

Adds two unit tests for convert_specs_to_dataframe that call it without condition_format or measurement_mapping_format, so the defaults are verified:

  • Default condition_format (normalize_conditions_per_column) produces condition_<name> columns, one row per spec.
  • Default measurement_mapping_format (normalize_measurement_mappings_per_column) produces measurement_mapping[<index>].filter and measurement_mapping[<index>].result_filter columns, one row per spec.

Why should this Pull Request be merged?

Previously, every test passed these format arguments explicitly, and the existing no-argument condition test used conditions without values, so it could not show which format the default applies. A change to either default would not have been caught.

What testing has been done?

  • python -m pytest tests/spec/test_spec_dataframe_utilitites.py -q - passed (16 passed)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Ahalya-ni
Ahalya-ni requested a review from hariram-ni November 19, 2026 07:29
@Ahalya-ni
Ahalya-ni marked this pull request as ready for review November 19, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants