Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hariram-ni
approved these changes
Nov 19, 2026
Ahalya-ni
marked this pull request as ready for review
November 19, 2026 07:39
Ahalya-ni
requested review from
cameronwaterman,
rbell517 and
spanglerco
as code owners
November 19, 2026 07:39
rbell517
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Adds two unit tests for
convert_specs_to_dataframethat call it withoutcondition_formatormeasurement_mapping_format, so the defaults are verified:condition_format(normalize_conditions_per_column) producescondition_<name>columns, one row per spec.measurement_mapping_format(normalize_measurement_mappings_per_column) producesmeasurement_mapping[<index>].filterandmeasurement_mapping[<index>].result_filtercolumns, one row per spec.Why should this Pull Request be merged?
Previously, every test passed these format arguments explicitly, and the existing no-argument condition test used conditions without values, so it could not show which format the default applies. A change to either default would not have been caught.
What testing has been done?
python -m pytest tests/spec/test_spec_dataframe_utilitites.py -q- passed (16 passed)