Repository navigation
Adding Unload and Reload Specification File example in NI-Digital - #2264
Draft
NI-velmurugan wants to merge 5 commits into
Draft
NI-velmurugan wants to merge 5 commits into
NI-velmurugan wants to merge 5 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2264 +/- ##
==========================================
- Coverage 88.97% 88.12% -0.86%
==========================================
Files 82 88 +6
Lines 20306 22830 +2524
==========================================
+ Hits 18068 20119 +2051
- Misses 2238 2711 +473
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
NI-velmurugan
changed the title
divakar-selvam07
approved these changes
Nov 12, 2026
| session.apply_levels_and_timing(levels_filename, timing_filename) | ||
|
|
||
| session.burst_pattern(start_label='startdemo') | ||
| site_number, captured_waveform = next(iter(session.fetch_capture_waveform(CAPTURE_WAVEFORM_NAME, len(source_waveform_data)).items())) |
Contributor
There was a problem hiding this comment.
The pin map defines four sites, but this reads only the first site’s waveform, if I'm not wrong.
Could we iterate over the returned dictionary to report results for every site?
Contributor
There was a problem hiding this comment.
Something like,
captured_waveforms = session.fetch_capture_waveform(CAPTURE_WAVEFORM_NAME, len(source_waveform_data))
for site_number, captured_waveform in captured_waveforms.items():
mismatch_fraction = _count_mismatched_bits(source_waveform_data, captured_waveform) / total_bits
print('Site {}: {}={:g}, {}={:g}: {:.4f}'.format(site_number, x_spec_name, x_value, y_spec_name, y_value, mismatch_fraction))| mismatch_fraction = _count_mismatched_bits(source_waveform_data, captured_waveform) / total_bits | ||
| print('Site {}: {}={:g}, {}={:g}: {:.4f}'.format(site_number, x_spec_name, x_value, y_spec_name, y_value, mismatch_fraction)) | ||
|
|
||
| print('Done sweeping specifications') |
Contributor
There was a problem hiding this comment.
Let's print this at the end after disconnecting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- [ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
This PR adds
nidigital_unload_and_reload_specifications_file.pya Python adaptation of the LabVIEWNI-Digital Unload and Reload Specifications File.vialong with the supporting digital pattern editor project files.What testing has been done?
Manually validated the example using simulated hardware only.
Ref #2254 (comment) for skipping the HW validation.