[NI-velmurugan]

• This contribution adheres to CONTRIBUTING.md.
• I've updated CHANGELOG.md if applicable.
  - [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

This PR adds nidigital_load_sheets_and_burst.py, a Python adaptation of the LabVIEW NI-Digital Load Sheets and Burst.vi along with the supporting digital pattern editor project files.

What testing has been done?

Manually validated the example using simulated hardware only.
Ref #2254 (comment) for skipping the HW validation.

[azure-pipelines]

Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.98%. Comparing base (9b70885) to head (dfb9f45).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2257      +/-   ##
==========================================
+ Coverage   88.12%   88.98%   +0.86%     
==========================================
  Files          88       82       -6     
  Lines       22830    20306    -2524     
==========================================
- Hits        20118    18069    -2049     
+ Misses       2712     2237     -475     

Flag	Coverage Δ
codegenunittests	84.78% <ø> (ø)
nidcpowersystemtests	94.40% <ø> (+0.04%)	⬆️
nidcpowerunittests	89.53% <ø> (ø)
nidigitalsystemtests	92.04% <ø> (ø)
nidigitalunittests	68.43% <ø> (ø)
nidmmsystemtests	92.33% <ø> (ø)
nifakeunittests	86.08% <ø> (ø)
nifgensystemtests	94.34% <ø> (ø)
nimodinstsystemtests	73.85% <ø> (ø)
nimodinstunittests	94.20% <ø> (ø)
nirfsasystemtests	82.71% <ø> (ø)
nirfsaunittests	63.37% <ø> (ø)
nirfsgsystemtests	?
niscopesystemtests	89.99% <ø> (ø)
niscopeunittests	43.20% <ø> (ø)
nisesystemtests	91.50% <ø> (ø)
niswitchsystemtests	81.66% <ø> (ø)
nitclksystemtests	94.87% <ø> (ø)
nitclkunittests	98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[NI-velmurugan]

@jarnoldNI, the PR is ready for your review.

[marcoskirsch]

Sometimes examples have a common prefix: https://github.com/ni/nimi-python/tree/master/src/nidmm/examples

This don't.

• What is the convention within nimi-python?
• What is the wider convention across NI Python APIs?

[NI-velmurugan]

Sometimes examples have a common prefix: https://github.com/ni/nimi-python/tree/master/src/nidmm/examples

This don't.

• What is the convention within nimi-python?
• What is the wider convention across NI Python APIs?

Thanks for the review, @marcoskirsch

Convention within nimi-python: Example scripts are prefixed with the driver name, for example nidmm_*.py, niscope_*.py, nidcpower_*.py and nifgen_*.py. This example follows that convention: nidigital_load_sheets_and_burst.py.

The folder layout is the only difference. nidigital examples need Digital Pattern Editor project files (.digiproj, .pinmap, .digipat, and so on), so each example lives in its own subfolder with an unprefixed name. The existing nidigital examples are laid out the same way as this one.

Reference: burst_with_start_trigger/nidigital_burst_with_start_trigger.py

This PR uses the same structure: load_sheets_and_burst/nidigital_load_sheets_and_burst.py.

Are you expecting any naming changes here, such as a nidigital_ prefix on the folder names? If so, I'd prefer to rename all the nidigital examples together in a separate PR, so this PR stays consistent with the existing ones.