Skip to content

Use Node 26 in main workflow - #3121

Merged
rajsite merged 3 commits into
mainfrom
users/jattas/node26
Nov 17, 2026
Merged

rajsite merged 3 commits into
mainfrom
users/jattas/node26

Conversation

@jattasNI

@jattasNI jattasNI commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request

🤨 Rationale

Node 26 is now LTS and we're using it in other NI pipelines.

👩‍💻 Implementation

Change main.yml workflow to use Node 26 instead of 24. This shouldn't change npm behavior since we're already overriding the npm version with a newer one (12.2) than what ships with Node 26 (11.2).

Also update version in CONTRIBUTING.md

🧪 Testing

Relying on pipeline. I inspected the node and npm setup steps and didn't see any new warnings.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@jattasNI
jattasNI marked this pull request as ready for review November 12, 2026 15:18
@jattasNI
jattasNI requested a review from rajsite as a code owner November 12, 2026 15:18
@jattasNI
jattasNI enabled auto-merge (squash) November 12, 2026 15:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the update aligning CI and contributor prerequisites on Node.js 26.

No open issues 🎉

What changed in this PR

Updates Nimble’s main CI workflow and contributor setup instructions to use Node.js 26, keeping the documented minimum aligned with CI.

Changes:

  • Switch the main workflow from Node.js 24 to 26 while retaining the npm 12 override.
  • Raise the documented Node.js prerequisite from 24+ to 26+.
File Description
CONTRIBUTING.md Updates the required Node.js version to 26+.
.github/​workflows/​main.yml Configures the main workflow to use Node.js 26.

Review effort: Balanced

@rajsite

rajsite commented Nov 17, 2026

Copy link
Copy Markdown
Member

@jattasNI consider updates for style guide and ni/fast if you have a chance

@rajsite
rajsite requested a balanced review from Copilot and removed request for Copilot November 17, 2026 23:48
@rajsite
rajsite disabled auto-merge November 17, 2026 23:49
@rajsite
rajsite merged commit d8f4d97 into main Nov 17, 2026
15 of 16 checks passed
@rajsite
rajsite deleted the users/jattas/node26 branch November 17, 2026 23:49
@jattasNI

Copy link
Copy Markdown
Contributor Author

@jattasNI consider updates for style guide and ni/fast if you have a chance

ni/javascript-styleguide#201
ni/fast#57

jattasNI added a commit to ni/fast that referenced this pull request Nov 18, 2026
# Pull Request

## 📖 Description

Update main workflow to use Node 26 which is the active LTS version.
Similar to: ni/nimble#3121

### 🎫 Issues

N/A

## 👩‍💻 Reviewer Notes

N/A

## 📑 Test Plan

Relying on pipeline 

## ✅ Checklist

### General

<!--- Review the list and put an x in the boxes that apply. -->

- [ ] I have included a change request file using `$ yarn change`
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [x] I have updated the project documentation to reflect my changes.
- [x] I have read the
[CONTRIBUTING](https://github.com/microsoft/fast/blob/master/CONTRIBUTING.md)
documentation and followed the
[standards](/docs/community/code-of-conduct/#our-standards) for this
project.


## ⏭ Next Steps

N/A
jattasNI added a commit to ni/javascript-styleguide that referenced this pull request Nov 18, 2026
Update main workflow to use Node 26 which is the active LTS version.
Similar to: ni/nimble#3121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants