Repository navigation
Use Node 26 in main workflow - #3121
Merged
Merged
Conversation
jattasNI
marked this pull request as ready for review
November 12, 2026 15:18
jattasNI
enabled auto-merge (squash)
November 12, 2026 15:19
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the update aligning CI and contributor prerequisites on Node.js 26.
No open issues 🎉
What changed in this PR
Updates Nimble’s main CI workflow and contributor setup instructions to use Node.js 26, keeping the documented minimum aligned with CI.
Changes:
- Switch the main workflow from Node.js 24 to 26 while retaining the npm 12 override.
- Raise the documented Node.js prerequisite from 24+ to 26+.
| File | Description |
|---|---|
| CONTRIBUTING.md | Updates the required Node.js version to 26+. |
| .github/workflows/main.yml | Configures the main workflow to use Node.js 26. |
Review effort: Balanced
Member
|
@jattasNI consider updates for style guide and ni/fast if you have a chance |
rajsite
approved these changes
Nov 17, 2026
rajsite
requested
a balanced review from Copilot
and removed request for
Copilot
November 17, 2026 23:48
rajsite
approved these changes
Nov 17, 2026
rajsite
disabled auto-merge
November 17, 2026 23:49
Copilot stopped reviewing on behalf of
rajsite due to an error
November 17, 2026 23:52
This was referenced Nov 18, 2026
Contributor
Author
|
jattasNI
added a commit
to ni/fast
that referenced
this pull request
Nov 18, 2026
# Pull Request ## 📖 Description Update main workflow to use Node 26 which is the active LTS version. Similar to: ni/nimble#3121 ### 🎫 Issues N/A ## 👩💻 Reviewer Notes N/A ## 📑 Test Plan Relying on pipeline ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [ ] I have included a change request file using `$ yarn change` - [ ] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. - [x] I have read the [CONTRIBUTING](https://github.com/microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](/docs/community/code-of-conduct/#our-standards) for this project. ## ⏭ Next Steps N/A
jattasNI
added a commit
to ni/javascript-styleguide
that referenced
this pull request
Nov 18, 2026
Update main workflow to use Node 26 which is the active LTS version. Similar to: ni/nimble#3121
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Node 26 is now LTS and we're using it in other NI pipelines.
👩💻 Implementation
Change main.yml workflow to use Node 26 instead of 24. This shouldn't change npm behavior since we're already overriding the npm version with a newer one (12.2) than what ships with Node 26 (11.2).
Also update version in CONTRIBUTING.md
🧪 Testing
Relying on pipeline. I inspected the node and npm setup steps and didn't see any new warnings.
✅ Checklist