Repository navigation
Mark several recommended Playwright rules as error instead of warning - #202
Merged
Merged
Conversation
jattasNI
marked this pull request as ready for review
November 18, 2026 22:01
rajsite
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Justification
While investigating a suggestion to enable a new Playwright rule I noticed that several existing recommended rules are marked as warnings rather than errors. We have a policy of avoiding warnings because they are easily ignored.
Implementation
These rules all seem reasonable to me so I propose enabling them as errors. Check out the rule comments for more info.
Some of the rules are only available in a newer edition of the ruleset so I'm bumping the peer dependency version.
The remaining three recommended rules I'm not enabling are stylistic. I'm open to opinions about enforcing them or turning them off.
Testing
I locally built the package and tested it against the Skyline Web acceptance tests. Most of the rules are already being obeyed but it identified 11 new failures.
no-wait-for-selectorerrors in FeedManager, for example these are waiting and then asserting, which is redundant.no-conditional-expecterrors in SystemsManagement, for example this if/else which is at a minimum hard to reason about and possibly also failing to hit one of the assert cases