Skip to content

Address dependabot issues in example notebooks - #207

Merged
mjohanse-emr merged 1 commit into
mainfrom
users/mjohanse/more_dependabot
Nov 19, 2026
Merged

mjohanse-emr merged 1 commit into
mainfrom
users/mjohanse/more_dependabot

Conversation

@mjohanse-emr

Copy link
Copy Markdown
Contributor

What does this Pull Request accomplish?

Updates the following versions to remediate CVE/dependabot issues.

  • soupsieve (CVE affects <= 2.10) --> 4.0.1
  • tornado (CVE affects <= 6.6.0) --> 6.6.1

In order to depend on soupsieve > 2.10, I had to increase the minimum python version to 3.11.5. This is different than the distribution component and other examples, which have a minimum of 3.11.0. I think this is a reasonable trade-off to resolve security issues.

Why should this Pull Request be merged?

Remediate CVEs

What testing has been done?

Ensured poetry install succeeds for the notebooks.

Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
@mjohanse-emr
mjohanse-emr requested a review from a team as a code owner November 19, 2026 15:10
Copilot AI balanced review requested due to automatic review settings November 19, 2026 15:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The notebook setup guides do not document the new Python 3.11.5 minimum, so users on 3.11.0–3.11.4 may encounter installation failures unexpectedly.

1 open issue
What changed in this PR

Updates the shared notebook environment to address reported dependency vulnerabilities while leaving the library’s Python requirements unchanged.

Changes:

  • Raises the notebook environment’s minimum Python version to 3.11.5.
  • Removes the locked SoupSieve 2.10 variant in favor of 4.0.1 and upgrades Tornado to 6.6.1.
File Description
examples/​notebooks/​pyproject.toml Raises both Python constraints to 3.11.5 and explains the security rationale.
examples/​notebooks/​poetry.lock Updates dependency versions, hashes, and Python compatibility metadata.

Review effort: Balanced

Comment thread examples/notebooks/pyproject.toml Resolved
@mjohanse-emr
mjohanse-emr merged commit aec147e into main Nov 19, 2026
36 checks passed
@mjohanse-emr
mjohanse-emr deleted the users/mjohanse/more_dependabot branch November 19, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants