I2CDecoder: add I2C address justification setting - #1115
Open
cmair wants to merge 1 commit into
Open
Conversation
Add a UI setting to select left or right justified I2C addresses. The (new) default is right justified. Actual bus data is not changed. A downstream I2CRegisterDecoder uses the same address format as the upstream I2CDecoder.
Author
|
This is my first attempt to display 7-bit addresses within I²C decode traces. The code seems to work, but I'm not sure if everything fits into the bigger picture as I just started to dig around. I'm happy to accept feedback! I've chosen left/right instead of 7/8-bit due to ngscopeclient/scopehal-apps#1014 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a UI setting to select left or right justified I2C addresses. The (new) default is right justified. Actual bus data is not changed.
A downstream I2CRegisterDecoder uses the same address format as the upstream I2CDecoder.