Repository navigation
fix(overlay): highlight boxes let clicks through to the flagged element (0.18.4) - #48
Merged
Merged
Conversation
A box over a flagged element took every click, so a flagged button couldn't be pressed and a flagged dialog (aria-dialog-name, say) was covered whole: its close button stopped working and the page needed a reload. The box is now pointer-events: none; the label alone takes clicks and scrolls to the element, as the docs already describe. Release 0.18.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the overlay on, each highlight box took every click. A flagged button couldn't be pressed, and a flagged dialog (for example one with no accessible name) was covered completely: its close button and every other control inside it stopped working. Escape was the only way out, and in an app that blocks Escape the page had to be reloaded.
The box is now
pointer-events: none. Only the label above it takes clicks, and clicking it scrolls to the element, as the docs already describe. The tooltip moved to the label.Tests: jsdom specs for the label click and the pointer-events values; the real-Chromium top-layer spec now checks the target is hit-testable through its box and that a real click on a button inside a fully highlighted modal dialog lands (fails on main). Full suite 435 pass.
Release 0.18.4.