Skip to content

Update paper.md - #549

Merged
jasmezz merged 2 commits into
nf-core:paper-comments-tinafrom
warinner:patch-1
Sep 14, 2026
Merged

jasmezz merged 2 commits into
nf-core:paper-comments-tinafrom
warinner:patch-1

Conversation

@warinner

Copy link
Copy Markdown

Editing of manuscript to reduce length, reduce repetition, and clarify arguments. Also, I made the order of the genes/functions consistent throughout the manuscript to match the title. They now always appear BGC first, then AMPs, then ARGs, then CAZymes/CGCs.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/funcscan branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Editing of manuscript to reduce length, reduce repetition, and clarify arguments. Also, I made the order of the genes/functions consistent throughout the manuscript to match the title. They now always appear BGC first, then AMPs, then ARGs, then CAZymes/CGCs.

@jasmezz jasmezz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your improvements and rephrasing, @warinner. Looking good to me, I just added tiny spelling/puntuation fixes.

TODO: Decide whether we strictly follow BE or AE spelling – things like comma or not after "e.g." are not clear, yet (@jfy133).

Comment thread paper/paper.md Outdated
Comment thread paper/paper.md Outdated
Comment thread paper/paper.md Outdated
Comment thread paper/paper.md Outdated
@warinner

warinner commented Sep 14, 2026 via email

Copy link
Copy Markdown
Author

Co-authored-by: Jasmin Frangenberg <73216762+jasmezz@users.noreply.github.com>
@jasmezz

jasmezz commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

That sounds good. I'll merge this PR with your improvements so that others have a clean version to read/comment on.

@jasmezz
jasmezz merged commit 80288ba into nf-core:paper-comments-tina Sep 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants