Repository navigation
fix(skill-tree): fail-closed trust for skillx releases (AgentKit G0 row 38) - #95
Merged
Merged
Conversation
A SkillX registry signature is not a publisher signature, so no skillx input (verified flag, empty, whitespace or null origin) can raise trust above local-unverified. Vendor the AgentKit dev identity vectors that pin this and cover the origin and verified combinations. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trustOfno longer returnspublisher-signedfor providerskillx: a SkillX registry signature is not a publisher signature, so every skillx row islocal-unverifiedregardless ofverifiedor origin (empty, whitespace, null). Only aremote-signedkit without overlay issigned-kit.identity-v1-vectors.jsonfrom bestagentkits/agentkitdev@5a7578ba(pins updated inPROVENANCE.mdandprovenance.test.ts). This is the vector change behind AgentKit G0 acceptance row 38 (bestagentkits/agentkit#2521, tracking #2524).Matches
docs/api-reference.md("consumers MUST NOT map these releases to trustpublisher-signed").Test plan
pnpm test: 97 files, 2067 passed, 2 skippedpnpm typecheck🤖 Generated with Claude Code