You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(cli): call isCompatibilityActionable instead of mirroring the rule #48
packages/contracts owns the real rule (isCompatibilityActionable, with the vocabulary in COMPATIBILITY_STATUSES). Two implementations of one rule is exactly the drift the cross-surface parity suite in PR #41 exists to catch — and the CLI is the one surface that suite cannot reach.
Making the CLI import @skillx/contracts requires changing how the published artifact is bundled:
packages/cli/tsconfig.json sets rootDir: "./src", so any import outside src/ fails typecheck;
tsup treats dependencies as external by default, and @skillx/contracts ships TypeScript source with no compile step, so it has to go in devDependencies and be force-bundled (noExternal), together with the tsconfig paths entry that the bundler needs to resolve it.
Getting that wrong breaks the npm publish path, which release-please triggers automatically on merge to main. That is a poor trade for a one-line predicate.
Mitigation already in place
packages/contracts/src/compatibility.test.ts pins COMPATIBILITY_STATUSES to an explicit list, with a comment naming this mirror. Adding a sixth status now fails that test instead of silently leaving the CLI wrong.
What the fix needs
Add @skillx/contracts to packages/clidevDependencies as workspace:*.
Add the tsconfig paths entry and drop or widen rootDir.
Add noExternal: ['@skillx/contracts'] to tsup.config.ts.
Delete the mirrored predicate and delegate to the contract.
Verify at the artifact level, not just in source: run the CLI bundler, then execute the resulting CLI (node bin/skillx.js check <slug> --target <runtime>) and confirm the bundle inlined the rule instead of leaving an unresolvable import.
Acceptance
The shipped CLI reports the same actionable decision as isCompatibilityActionable for all five statuses.
pnpm test still passes, and the parity test's note about the CLI limitation can be removed.
Shipped: fixed by #97 (squash 79f98fb, merged 2026-10-20 after isolated re-review CLEAN at 2be37c3). Deployed to production skillx-web (worker version 7d29ff0a). The CLI change ships to npm with the next release-please release.
Activity
docs(plans): record the post-review hardening
refactor(cli): delegate actionability to isCompatibilityActionable
refactor(cli): delegate actionability to isCompatibilityActionable
refactor(cli): delegate actionability to isCompatibilityActionable
feat: finish Phase 1 discovery (CLI envelope, get_kit, WebMCP mirror,…
mrgoonie commentedon Oct 20, 2026
Shipped: fixed by #97 (squash 79f98fb, merged 2026-10-20 after isolated re-review CLEAN at 2be37c3). Deployed to production skillx-web (worker version 7d29ff0a). The CLI change ships to npm with the next release-please release.