feat: Port to config lexicon - #1322
Merged
Merged
Conversation
CarlSchwan
requested review from
grnd-alt,
hweihwang and
juliusknorr
as code owners
September 1, 2026 13:19
hweihwang
previously requested changes
Sep 11, 2026
1 task
Contributor
|
Carl, I’ve opened #1340 against your branch to fix the Nextcloud 31 error and the JWT setup command. Playwright now also checks that the secret was saved. All 118 PHP tests pass locally on Nextcloud 31, 32, and 35. I haven’t run the full Playwright suite locally. |
This in particular make the jwt_secret_key marked as sensitive Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Keep configuration keys independent of the optional lexicon API and only register the lexicon where ILexicon is available. Set the JWT secret with an explicit string type, avoid interactive prompts in Playwright, and verify the saved value. Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
hweihwang
force-pushed
the
carl/configlexicon
branch
from
September 16, 2026 09:06
886a689 to
3b8a00e
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This in particular make the jwt_secret_key marked as sensitive
🤖 AI (if applicable)