feat: Implement IAlternativeLoginProvider - #1176
Merged
Merged
Conversation
CarlSchwan
force-pushed
the
carl/list-saml-idp-login-page
branch
4 times, most recently
from
July 13, 2026 13:56
8811c06 to
c04b8d4
Compare
come-nc
approved these changes
Jul 13, 2026
CarlSchwan
force-pushed
the
carl/list-saml-idp-login-page
branch
from
July 14, 2026 10:45
c04b8d4 to
dae34f9
Compare
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/list-saml-idp-login-page
branch
from
July 16, 2026 12:05
dae34f9 to
dbb8a65
Compare
CarlSchwan
enabled auto-merge
July 16, 2026 12:11
| } | ||
|
|
||
| $redirectUrl = $this->request->getParam('redirect_url') ?? ''; | ||
| $absoluteRedirectUrl = $this->urlGenerator->getAbsoluteURL($redirectUrl); |
Member
There was a problem hiding this comment.
I believe this code path, which leads to a later call to getIdps() then getSSOUrl() results in the absolute version of the redirecturl being duplicated. Symptoms reported on the community help forum: https://help.nextcloud.com/t/double-url-with-saml-app-azure-loginpage-wrong-redirect/247252
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI (if applicable)