Skip to content

fix(tests): toggle link providers by their switch role #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndyScherzinger wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tests): toggle link providers by their switch role #2988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions playwright/support/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@
.getByRole('button', { name: /^Create application$/ })
.first()
.click({ force: true })
await expect(page.locator('[data-cy="createContextModal"]')).toBeVisible()

Check failure on line 325 in playwright/support/commands.ts

View workflow job for this annotation

GitHub Actions / Playwright (master)

[chromium] › playwright/e2e/column-relation.spec.ts:98:2 › Test column relation › Relation labels render inside an application context 

  1) [chromium] › playwright/e2e/column-relation.spec.ts:98:2 › Test column relation › Relation labels render inside an application context 
    Error: expect(locator).toBeVisible() failed

    Locator: locator('[data-cy="createContextModal"]')
    Expected: visible
    Timeout: 30000ms
    Error: element(s) not found

    Call log:
      - Expect "toBeVisible" locator('[data-cy="createContextModal"]') with timeout 30000ms
      - waiting for locator('[data-cy="createContextModal"]')


       at support/commands.ts:325

      323 | 		.first()
      324 | 		.click({ force: true })
    > 325 | 	await expect(page.locator('[data-cy="createContextModal"]')).toBeVisible()
          | 	                                                             ^
      326 |
      327 | 	const input = page.locator('[data-cy="createContextTitle"]')
      328 | 	await input.clear()
        at createContext (/home/runner/work/tables/tables/playwright/support/commands.ts:325:63)
        at /home/runner/work/tables/tables/playwright/e2e/column-relation.spec.ts:149:3

const input = page.locator('[data-cy="createContextTitle"]')
await input.clear()
Expand Down Expand Up @@ -463,7 +463,7 @@
.last()
await navigateViaNavLink(page, tableLink)
await waitForAppToFinishLoading(page)
await expect(page.locator('h1').filter({ hasText: name }).first()).toBeVisible({

Check failure on line 466 in playwright/support/commands.ts

View workflow job for this annotation

GitHub Actions / Playwright (stable35)

[chromium] › playwright/e2e/rows-counter.spec.ts:11:2 › Row counter freshness › Navigation counters update for table and sibling view after adding a row 

  2) [chromium] › playwright/e2e/rows-counter.spec.ts:11:2 › Row counter freshness › Navigation counters update for table and sibling view after adding a row 
    Error: expect(locator).toBeVisible() failed

    Locator: locator('h1').filter({ hasText: 'Counter sync table' }).first()
    Expected: visible
    Timeout: 45000ms
    Error: element(s) not found

    Call log:
      - Expect "toBeVisible" locator('h1').filter({ hasText: 'Counter sync table' }).first() with timeout 45000ms
      - waiting for locator('h1').filter({ hasText: 'Counter sync table' }).first()


       at support/commands.ts:466

      464 | 	await navigateViaNavLink(page, tableLink)
      465 | 	await waitForAppToFinishLoading(page)
    > 466 | 	await expect(page.locator('h1').filter({ hasText: name }).first()).toBeVisible({
          | 	                                                                   ^
      467 | 		timeout: APP_LOAD_TIMEOUT,
      468 | 	})
      469 | }
        at loadTable (/home/runner/work/tables/tables/playwright/support/commands.ts:466:69)
        at /home/runner/work/tables/tables/playwright/e2e/rows-counter.spec.ts:18:3
timeout: APP_LOAD_TIMEOUT,
})
}
Expand Down Expand Up @@ -605,22 +605,22 @@
.click()
await expect(page.getByText('Allowed types')).toBeVisible()

await setCheckboxState(
page.getByRole('checkbox', { name: /^URL$/i }),
false,
)
await setCheckboxState(
page.getByRole('checkbox', { name: /^Files$/i }),
false,
)
const providerSwitches = page.locator('.typeSelection').getByRole('switch')
await expect(providerSwitches.first()).toBeVisible()

const providerCount = await providerSwitches.count()
for (let index = 0; index < providerCount; index++) {
await setCheckboxState(providerSwitches.nth(index), false)
}

for (const provider of ressourceProvider) {
await setCheckboxState(
page.getByRole('checkbox', {
const providerSwitch = page
.locator('.typeSelection')
.getByRole('switch', {
name: new RegExp(`^${escapeRegExp(provider)}$`, 'i'),
}),
true,
)
})
await expect(providerSwitch).toHaveCount(1)
await setCheckboxState(providerSwitch, true)
}
await page
.locator('.modal-container button')
Expand Down
Loading