feat(dashboard): Show triggered reminders instead of upcoming ones - #19263
Open
nickvergessen wants to merge 1 commit into
Open
nickvergessen wants to merge 1 commit into
nickvergessen wants to merge 1 commit into
Conversation
nickvergessen
added
enhancement
feature: dashboard 🏠
Member
Author
|
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
feat/noid/show-triggered-reminders-on-dashboard
branch
from
September 4, 2026 07:29
0d656fe to
2b317d6
Compare
Antreesy
reviewed
Sep 14, 2026
Antreesy
left a comment
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
Tested in pair with notifications companion PR - works nicely, but I'm not fond of losing current feature
|
|
||
| const supportsUpcomingReminders = hasTalkFeature('local', 'upcoming-reminders') | ||
| const supportsReminders = hasTalkFeature('local', 'upcoming-reminders') || supportsTriggeredReminders | ||
| const remindersTitle = supportsTriggeredReminders ? t('spreed', 'Reminders') : t('spreed', 'Upcoming reminders') |
Contributor
There was a problem hiding this comment.
Placeholder element uses t('spreed', 'Message reminders'), maybe also reuse it here?
| async fetchReminders() { | ||
| if (supportsTriggeredReminders) { | ||
| await this.fetchTriggeredReminders() | ||
| } else { |
Contributor
There was a problem hiding this comment.
Why can't we keep both lists? Maybe with a divider
I find it useful personally to see future reminders as well
Contributor
There was a problem hiding this comment.
we can wire notifications openAPI via src/types/generate-core-types.sh and workflow update, to keep in sync
| * | ||
| * @param notification A notification with the object type `reminder` | ||
| */ | ||
| function parseReminderNotification(notification: NotificationsNotification): DashboardReminder { |
Contributor
There was a problem hiding this comment.
I'd move it to src/services/notificationsService.ts or separate util
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
AI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist