[stable34] always make user in external share manager explicit - #64670
Merged
Merged
Conversation
backportbot
Bot
requested review from
icewind1991,
leftybournes and
provokateurin
September 23, 2026 08:05
icewind1991
force-pushed
the
backport/64623/stable34
branch
from
September 23, 2026 08:16
bc88784 to
77e84de
Compare
the code is only called with non-accepted shares, so the method always returned early Signed-off-by: Robin Appelman <robin@icewind.nl>
relying on the session user is inconsistent as there might not be a logged in user, or the logged in user might not be the recipient of the share (reshares) Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
backport/64623/stable34
branch
from
September 23, 2026 08:26
77e84de to
53664d6
Compare
icewind1991
marked this pull request as ready for review
September 23, 2026 10:22
icewind1991
requested review from
salmart-dev
and removed request for
a team
September 23, 2026 10:22
provokateurin
approved these changes
Sep 23, 2026
icewind1991
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #64623
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.