Add back the firing of UserLoggedInEvent and deprecate PostLoginEvent - #64582
Merged
Merged
Conversation
come-nc
requested review from
icewind1991 and
leftybournes
and removed request for
a team
September 20, 2026 12:29
icewind1991
approved these changes
Sep 20, 2026
artonge
approved these changes
Sep 20, 2026
Contributor
Author
|
I guess the SSO error is related but I’m not sure what’s happening 🧐 |
When the listening on postLogin was removed, adding the UserLoggedInEvent was forgotten, I guess because there is already PostLoginEvent, but we do need to fire both of them for now. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…s the same UserLoggedInEvent is the correct naming, matching BeforeUserLoggedInEvent Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
And remove duplicated event firing. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
provokateurin
approved these changes
Sep 21, 2026
come-nc
force-pushed
the
fix/user-loggedin-event
branch
from
September 21, 2026 10:16
3b4540c to
78691bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The firing of UserLoggedInEvent was not correctly added back when the listener on postLogin dispatching it was removed.
This is because of the presence of duplicated PostLoginEvent which is confusing, so let’s deprecate that and move to the properly named event.
Checklist
3. to review, feature component)stable32)AI (if applicable)