[stable35] feat(files): bring back the Sidebar API - #64581
Merged
Merged
Conversation
backportbot
Bot
requested review from
AndyScherzinger,
CarlSchwan and
susnux
September 20, 2026 12:08
backportbot
Bot
added
enhancement
3. to review
Some apps have made use of the Files App Sidebar within their apps, like photots for example. This was dropped with Nextcloud 33 breaking those apps. Its not really feasible to implement the sidebar everytime the same, instead make it possible for apps to reuse the files sidebar again. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
The `files-main` and `files-sidebar` bundles both contain the sidebar modules, because the Webpack build only shares modules from `node_modules` between entry points. The data provider registered by the files app was therefore invisible to `initializeSidebar()` in the `files-sidebar` bundle, which rendered a second, standalone sidebar next to the one the files app already renders - so `#app-sidebar-vue` existed twice. Keep the data provider, the standalone provider and the mounted instance on `OCA.Files.Sidebar._sharedState` instead, so every entry point sees the same state - the same approach `getPinia()` already uses for the pinia instance. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
backport/63488/stable35
branch
from
September 20, 2026 12:19
a14f872 to
bed76d0
Compare
susnux
marked this pull request as ready for review
September 20, 2026 12:23
susnux
requested review from
kristian-zendato
and removed request for
a team
September 20, 2026 12:24
Merged
susnux
approved these changes
Sep 20, 2026
artonge
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #63488
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.