Skip to content

chore(core): drop the password reset hooks in favour of the typed events #64403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
Sep 16, 2026
+1 −3
Merged

chore(core): drop the password reset hooks in favour of the typed events #64403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions core/Controller/LostController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
/**
* Class LostController
*
* Successfully changing a password will emit the post_passwordReset hook.
* Successfully changing a password will dispatch a PasswordResetEvent.
*
* @package OC\Core\Controller
*/
Expand Down Expand Up @@ -203,7 +203,6 @@ public function setPassword(string $token, string $userId, string $password, boo
$user = $this->userManager->get($userId);

$this->eventDispatcher->dispatchTyped(new BeforePasswordResetEvent($user, $password));
\OC_Hook::emit('\OC\Core\LostPassword\Controller\LostController', 'pre_passwordReset', ['uid' => $userId, 'password' => $password]);

if (strlen($password) > IUserManager::MAX_PASSWORD_LENGTH) {
throw new HintException('Password too long', $this->l10n->t('Password is too long. Maximum allowed length is 469 characters.'));
Expand All @@ -214,7 +213,6 @@ public function setPassword(string $token, string $userId, string $password, boo
}

$this->eventDispatcher->dispatchTyped(new PasswordResetEvent($user, $password));
\OC_Hook::emit('\OC\Core\LostPassword\Controller\LostController', 'post_passwordReset', ['uid' => $userId, 'password' => $password]);

$this->twoFactorManager->clearTwoFactorPending($userId);

Expand Down
Loading